wtho

Results 84 comments of wtho

> Maybe use `fixture.nativeElement` instead of `fixture`. I think testing HTML template shouldn't use that `fixture` but rather than HTML elements rendering. Snapshotting `fixture.nativeElement` does solve the issue, as it...

👍 Already added a small note in the [README.md](https://github.com/thymikee/jest-preset-angular/pull/317/files#diff-04c6e90faac2675aa89e2176d2eec7d8R43). I know, it's not very visible, but someone who does read through the README will encounter it.

@BensonBen Yeah, a performance evaluation would be super helpful! I do not have a big codebase at hand currenlty. Maybe you can install jpa using `npm install -D git://github.com/wtho/jest-preset-angular.git#feat/babel-jest-angular` and...

True, we can keep the structure and just point it at ts-jest as default. I just liked the equality between the two options and disregarded backwards-compatibility. I would also suggest...

Interesting! Can you create a gist just containing the classes that have injection issues (and the classes/providers that could not be injected)? Decorators, classname and constructor signatures are sufficient. Methods,...

@ViceIce I tried out the tests and as soon as I add `@Injectable` to `MyHandler` it works in babel, but not in ts-jest, so this seems contradictary to what you...

While we have to wait for https://github.com/leonardfactory/babel-plugin-transform-typescript-metadata/pull/24, you guys can help us by doing further tests on bigger codebases. Please try out the babel preset using a branch where I...

Finally! I think that's no problem for the babel scenario (or the preset in general).

I think we can keep open just in case this gets interesting again. I'll make it a draft though.

Native html-forms should not be nested, as stated in the [html5 spec](https://www.w3.org/TR/html5/sec-forms.html#the-form-element): > 4.10.3. The form element > Content model: > Flow content, but with no element descendants. As `vue-form`...