William Godbe

Results 95 comments of William Godbe

Discussion issue here: https://github.com/dotnet/aspnetcore/issues/40273

Pushed update to run CompGov in every (internal) step, new build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1685978&view=results

Just pushed an update to resolve non-template bugs & enable ProjectReferences globally, @dougbu PTAL Build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1689034&view=results

> Changes appear incomplete I think we also need to turn `UseLatestPackageReferences` on globally - projects that aren't patching will use whatever's in the baseline (might not be latest), while...

> This feels like a sledgehammer when a small hammer would have done the trick. First, the external versions from the baselines were fine before; why aren't they now❔ Second,...

> For now, please limit the fix to the currently-failing case e.g. set $(UseLatestPackageReferences) to true just in Microsoft.AspNetCore.Server.IISIntegration.csproj. The settings in ResolveReferences.targets are all fallbacks if the project does...

> For release/2.1, latest package references are almost never the right thing to do Could you explain why? The way I see it, enabling latest package references has become a...

https://github.com/dotnet/aspnetcore-internal/pull/4034

I'm seeing lots of test failures like this in dotnet-watch: > Log Critical[0]: Unable to start Kestrel. System.InvalidOperationException: Dynamic port binding is not supported when binding to localhost. You must...