William Godbe

@sbomer looks like this was caused by https://github.com/dotnet/sdk/pull/29441 - is it intentional that we get these errors for netstandard2.1 projects that enable trimming? https://github.com/dotnet/aspnetcore/pull/45879#issuecomment-1371754009

> @wtgodbe Is it definitely the case that PublishTrimmed is set, or could these projects have IsTrimmable or EnableTrimAnalyzer set instead? netstandard2.1 didn't have annotations for trimming, but the 7.0...

> Setting IsTrimmable to false would prevent the library from being trimmed when consumed in apps, so it may not be what you want. I think our team needs to...

Remaining errors are all: > ##[error]src/Tools/LinkabilityChecker/LinkabilityChecker.csproj(47,5): error MSB4036: (NETCORE_ENGINEERING_TELEMETRY=Build) The "ILLink" task was not found. Check the following: 1.) The name of the task in the project file is the...

> f you want to avoid this for .NET 9 and onwards, consider setting DisableImplicitFrameworkReferences to true in RepoTasks.csproj as presumably that project doesn't need the framework references and the...

Don't think that'll work since our RepoTasks do use stuff from runtime. We can probably just apply the FrameworkReference workaround we give to non-Tools projects to RepoTasks to fix this...

https://github.com/dotnet/aspnetcore/issues/45973

I see, this did bring in the new `SourceIndexPackageVersion` from https://github.com/dotnet/arcade/issues/11995, but we overwrite that in ci.yml with an old version from 2021. We should probably just start using the...

Never mind, can't remove that because it's used directly before we get to eng/common. Opened https://github.com/dotnet/aspnetcore/pull/45982 to just update it

> @wtgodbe should we extend CodeCheck.ps1 to ensure ^resolved " lines also match "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public-npm/npm/registry/❔ That would avoid checking in broken changes like this one. Yeah, I'm on board. Should be...