Adam Woźny

Results 14 comments of Adam Woźny

After upgrade to Ember 4.4 we see the same problem but it completely crash app. Currently we're using workaround with `next`: ```js import { next } from '@ember/runloop'; // ......

Ahh read documentation from top to bottom... :) This is a solution and issue can be closed: ```js constructor() { super(...arguments); this.changeset = new Changeset( this.args.model, lookupValidator(InfoValidations), InfoValidations, { initValidate:...

Anyone got an idea how to fix this? We have the same reason as @NullVoxPopuli to use `shouldRecycle={{false}}`

> Hi @wozny1989 It seems that the ember-infinity blueprint component has not been refactored yet. [blueprints/infinity-template/files/app/templates/components/infinity-loader.hbs](https://github.com/wozny1989/ember-infinity/blob/bump-to-Ember-4-x/blueprints/infinity-template/files/app/templates/components/infinity-loader.hbs) @jahrock done 👍

> Looks like we need to update the node version used to allow these tests to run @RobbieTheWagner I just updated it, let's check

@RobbieTheWagner Now it should be fine, tested locally as well: ![image](https://github.com/adopted-ember-addons/ember-infinity/assets/36460224/d3c603ce-d7ef-40f6-b69d-de17abe1bd93)

> @wozny1989 it looks like we need to update node versions. Can you update engines in package.json and our ci.yml to enforce node 18+ please? @RobbieTheWagner Done 👍

@RobbieTheWagner Also I bumped `@embroider/test-setup`, locally embroider setup are passing 🤔 let's check on CI now

@RobbieTheWagner I just bumped to Ember 4.12.x, all tests are passing besides Embroider stuff. It's weird because locally on my machine Embroider `safe` and `optimized` passing without any problems, the...

On my fork CI have different output, but why? https://github.com/wozny1989/ember-infinity/pull/1