Upgrade to Ember 5

[wozny1989]

Tasks

• [x] Update all packages and Ember to version 5.8, support for >= 3.28
• [x] Migrate to addon v2
• [x] Fix error with content or passed custom params:

Uncaught Error: Assertion Failed: You attempted to update `perPageParam` on `<InfinityModel:ember129>`, but it had already been used previously in the same computation.  Attempting to update a value after using it in a computation can cause logical errors, infinite revalidation bugs, and performance issues, and is not supported.

[ndekeister-us]

Ping @snewcomer any chance we can have checks running for this PR? (and if they are passing, to have this PR merged)

Ember 5 is coming and we will need some changes in this project, I believe this PR is a good start (and in fact may be enough to have the compatibility with Ember 5)

[jahrock]

Hi @snewcomer & @hhff We would be very grateful if you could take the time to look at the PR.

[hhff]

Hi @jahrock - it's been a long time since I worked on Ember. @snewcomer - what do you think?

[jahrock]

Hi @hhff Thanks for your feedback. Would it be an option for you to transfer the addon ownership to "adopted ember addons" so that interested developers can get involved?

The effort is quite low and can be achieved through the linked process. https://github.com/adopted-ember-addons/program-guidelines/blob/master/README.md

[hhff]

Yes, absolutely. Let me look into this and I'll get back to you!

On Tue, Apr 2, 2024 at 3:17 PM Jah Rock @.***> wrote:

Hi @hhff https://github.com/hhff Thanks for your feedback. Would it be an option for you to transfer the addon ownership to "adopted ember addons" so that interested developers can get involved?

The effort is quite low and can be achieved through the linked process.

https://github.com/adopted-ember-addons/program-guidelines/blob/master/README.md

— Reply to this email directly, view it on GitHub https://github.com/ember-infinity/ember-infinity/pull/470#issuecomment-2032893705, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAV3R7CHLSD2W45PZNKEMQDY3L76JAVCNFSM6AAAAAAYZELAGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSHA4TGNZQGU . You are receiving this because you were mentioned.Message ID: @.***>

-- Hugh Francis

c/o Sanctuary Computer, Inc 120 Walker, FL3 New York, NY 10013 sanctuary.computer https://www.sanctuary.computer

[jahrock]

Hi @hhff You can transfer the github repository to @RobbieTheWagner. Keep in mind to provide him access to npm.js as well.

[RobbieTheWagner]

Hi @hhff You can transfer the github repository to @RobbieTheWagner. Keep in mind to provide him access to npm.js as well.

I am rwwagner90 on npm

[jahrock]

Hi @wozny1989 It seems that the ember-infinity blueprint component has not been refactored yet. blueprints/infinity-template/files/app/templates/components/infinity-loader.hbs

[wozny1989]

Hi @wozny1989 It seems that the ember-infinity blueprint component has not been refactored yet. blueprints/infinity-template/files/app/templates/components/infinity-loader.hbs

@jahrock done 👍

[RobbieTheWagner]

Looks like we need to update the node version used to allow these tests to run

[wozny1989]

Looks like we need to update the node version used to allow these tests to run

@RobbieTheWagner I just updated it, let's check

[RobbieTheWagner]

@wozny1989 shouldn't we also update the ember-try scenarios to include 4.x versions, and beta and canary and such? I think we should ember-cli-update and do whatever the blueprints do there probably.

[wozny1989]

@RobbieTheWagner Now it should be fine, tested locally as well:

[RobbieTheWagner]

@wozny1989 it looks like we need to update node versions. Can you update engines in package.json and our ci.yml to enforce node 18+ please?

[wozny1989]

@wozny1989 it looks like we need to update node versions. Can you update engines in package.json and our ci.yml to enforce node 18+ please?

@RobbieTheWagner Done 👍

[wozny1989]

@RobbieTheWagner Also I bumped @embroider/test-setup, locally embroider setup are passing 🤔 let's check on CI now

[RobbieTheWagner]

@wozny1989 looks like still some embroider errors around ESM stuff

[wozny1989]

@RobbieTheWagner I just bumped to Ember 4.12.x, all tests are passing besides Embroider stuff. It's weird because locally on my machine Embroider safe and optimized passing without any problems, the problem is only on CI. Do you have any ideas?

[wozny1989]

On my fork CI have different output, but why? https://github.com/wozny1989/ember-infinity/pull/1

[wozny1989]

@RobbieTheWagner Finally I migrated addon to more embroider friendly addon v2, please re-run CI and let's keep finger crossed 🤞 fyi @jahrock

[RobbieTheWagner]

A v2 addon is definitely what we want for the future, but this is quite a lot to review now 😅

[jahrock]

As I see, many addons get ported from npm to pnpm. Would it make sense to give it a try?

[wozny1989]

A v2 addon is definitely what we want for the future, but this is quite a lot to review now 😅

@RobbieTheWagner Sorry for that! I had no other idea how to fix the tests on Embroider 😅

As I see, many addons get ported from npm to pnpm. Would it make sense to give it a try?

@jahrock I just migrated to pnpm, please review when you have time 🙈

[wozny1989]

Finally I bumped to Ember 5, now we have support for Ember >= 3.28.x

[wozny1989]

@jahrock Thanks for review, just added scenarios for LTS 4.12 and 5.8 👍

[jahrock]

Hi @RobbieTheWagner what do you think, are we ready to merge?

[mansona]

I've noticed a few issues with this but I'll fix it after merging since it's such a large PR to review 🙈