Wouter de Jong

Results 145 comments of Wouter de Jong

> @wouterj but if we are after the last written argument value, we still want completion for a next one in case of an infinite list. That's what I'm unsure...

I agree with the "let's see case-by-case" approach. I was maybe a bit too strict with my `match` PR review. If a change is scoped (not a lot of changes),...

Fixing code style is also different from the purpose of this issue, which is about modernizing the code base. Let's keep these discussion separate. For reference, because of the potential...

Thanks @jvasseur! I'm not using this bundle, so wasn't aware of the difference between those annotations.

This is now documented in the library, I don't think we have to document it in the bundle?

Sorry, this was so long buried in my notifications that I didn't know this was blocking on me. I've shared my idea now :)

I think this should instead be fixed on the EasyAdminBundle. This bundle doesn't have any specific integration of EasyAdminBundle, so I don't think it makes sense to modify priorities to...

If this is really going to be a documented feature, it should be included in the bundle's config & set by the extension imo. You should never have to change...

Please note that the current vagrant integration is not really great: https://github.com/symfony-cmf/cmf-sandbox/issues/266 , #294

This reveals something that I didn't discover before: Do we really need to have `SitemapAwareInterface` in all documents that we want to display in the sitemap? I don't like it...