Wouter de Jong

Hi! Thanks for creating this issue. My personal opinion on this is that it is not yet worth all the hassle (this is a complex BC path to maintain and...

> just check if the class Lock exists, and let the user enable the config Let's go for this option. The check (and exception) is "only" a DX improvement anyways:...

Thanks for checking all tests! (btw, I'll look at the PR somewhere after 6.1 is released) > `PHPUnit / Tests (8.2) (pull_request)`: the error reported here: https://github.com/symfony/symfony/runs/6538975401?check_suite_focus=true#step:8:2110 is related to...

@Spomky if you click on the "load more ...", you'll see a review from me. I guess GitHub immediately hid it, so it got lost 🙂

> I'm just wondering about those `array-key` and `array`: don't we prefer using `Foo[]`? I agree about `array-key`: afaik this is the default and I don't see a point in...

This one is ready to merge now imho

> Depending on $k, this may access the array with a non scalar key. Should we modify the code and throw an exception or should we specify $k harder? This...

Yes, I would either implement the "core way"/"Symfony CLI way" or don't implement anything at all.

@gnugat it can't be removed, as it's there for BC reasons. I think there are 2 options: 1. Instead of adding it as first search strategy, add it as last,...

@gnugat I think this will do (didn't test it though): ``` php $editor = EditorFactory::createEditor(); $editor->findBelow('something'); ```