cmf-sandbox
cmf-sandbox copied to clipboard
symfony-cmf
implement sitemap and error handling of seo-bundle
This PR implement the site map and error handling of seo-bundle.
It removes the SandboxExceptionListener and shows a nice error page. The sitmap can be found under the SEO stuff.
This reveals something that I didn't discover before: Do we really need to have SitemapAwareInterface in all documents that we want to display in the sitemap?
I don't like it that much. Can we maybe add a config option to whitelist FQCN of all documents that should be included in the sitemap?
@wouterj from my POV i like interfaces more than configuration. In that case the interface forces to implement isVisibleOnSitemap(), which is more than a decider for true false. You can decide based on your application/bussiness logic there. So a document can be on a sitemap in one case and not for the other case. And an other point for the interface is the chance to use different named sitemaps (is implemented) So the decider can vote on a special sitemap.
@ElectricMaxxx well, we can support both (decision is made using voters, isn't it?). This would result in the following decision flow for instance:
Can we move that discussion and the visualization into an issue. I think it shouldn't stop the implementation of the current usage here, right? Btw the way you painted it forces a user to do the decision twice. So what about having them side by side?
Btw, I'm planning on restructuring the sandbox to put all feature demo's in under one Feature page. The extra benefit is that it would make the hierarchy a lot complexer (and thus a nicer demo).
@wouterj great idea. lets get this merged first, however.
@ElectricMaxxx can you do the changes wouter asked for and then we merge?
Yea that PR misses the admins at the former places. So let's implement them first and rebase that one then.