WordPress Fan

Results 70 comments of WordPress Fan

After discussing this with @DahmaniAdame he mentioned that we can go with the current PR if the only issue is that `import inside import` and open another GH issue to...

@Miraeld I like the idea of having data attributes, just a small note, plz use `wpr_` as a prefix to make sure that it won't conflict with any other js....

Created this issue as a follow up: https://github.com/wp-media/wp-rocket/issues/7494

Sent to ready for QA based on this discussion: https://group-onecom.slack.com/archives/C08EFCYRQ2X/p1752117316919649?thread_ts=1752053118.937739&cid=C08EFCYRQ2X

Seems like this is merged in 3.20, exactly here: https://github.com/wp-media/wp-rocket/pull/7578

I think we need to wait a bit before merging this PR because we got some issues with taxonomy pages PR and the solution here is exactly the same. Those...

When handling this issue, we need to refactor this method: https://github.com/wp-media/wp-rocket/blob/7df15529f858b1da9fd3a2127f7b4b96664f99d5/inc/Engine/Media/AboveTheFold/WarmUp/Controller.php#L242-L249 To remove doing the version check and just change the default value for mobile options to be `1` instead...

For @wp-media/qa-team you can use the following snippet to completely disable mobile cache options to be used to validate the mentioned AC: ``` add_filter( 'pre_get_rocket_option_cache_mobile', '__return_false' ); add_filter( 'pre_get_rocket_option_do_caching_mobile_files', '__return_false'...

I can confirm that the provided fix is working from my side, I was trying to find why we used to use this priority `-1000` and I found that we...