WordPress Fan
WordPress Fan
I tested when using RocketCDN here: https://new.rocketlabsqa.ovh/next-gen-image/ and all good I believe, so we are fine here.
This PR was a POC to validate the idea, so it needs to be adapted to be a real PR, like fixing phpcs and tests.
I'm working on tests now
> We'll display a (success/warning/info) dismissible notice in the WP Rocket plugin settings page This point is still not handled by this grooming, correct? @Khadreal
I'm not talking about the dismiss, I'm talking about the notice itself, I believe we need to show it in WPR settings along with rocketCDN settings page. cc @piotrbak
# Grooming Will take the grooming mentioned above by @Khadreal with some small changes. ## Proposed Solution In this subscriber: https://github.com/wp-media/wp-rocket/blob/73488699424f726bef28dbf2c934340efcab8e47/inc/Engine/CDN/RocketCDN/DataManagerSubscriber.php#L50 Add a new callback to that array `update_cdn_name`, this...
Thanks @joejoe04 May I ask, what is the reason behind having our constant inside `wp-config.php`? From my point of view, I think those constants are forming the base functionality of...
Thanks @joejoe04 I wasn't aware that we have something like that in our docs :) In this case, you are correct.
We need to discuss this, plz don't groom for now.
No, let's block it exactly as @Miraeld , and if needed we can validate later and go ahead with the PR