wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Update Berlindb to latest version

Open wordpressfan opened this issue 1 year ago • 3 comments

Describe the bug As reported by our awesome @alfonso100 In this issue https://github.com/wp-media/wp-rocket/issues/6460 we managed to stop using SHOW TABLES LIKE inside the plugin and then in berlindb repository, we opened a github issue and its corresponding PR that got merged but never been release from berlindb side, that's why when we updated the package using composer, it didn't get all those fixes from there.

also seems like we pushed this commit https://github.com/wp-media/wp-rocket/commit/e943fa1754900948dd47f29dfd876106a4b5dfca on the fly :D and didn't get merged into develop at all.

To Reproduce Steps to reproduce the behavior:

  1. You can check the code directly here
  2. You will see that we still use the older version of query.

Expected behavior We should update berlindb to latest version, I added a comment here https://github.com/berlindb/core/issues/165#issuecomment-2565145521 once we get a reply and have the new berlindb version, we can update the version using composer.

Additional context Slack discussion: https://wp-media.slack.com/archives/C08N8J6VC/p1734378350301889

wordpressfan avatar Dec 30 '24 08:12 wordpressfan

thanks @wordpressfan! We have a related ticket: https://secure.helpscout.net/conversation/2820749734/535417?viewId=273761

alfonso100 avatar Jan 15 '25 19:01 alfonso100

Related ticket: https://secure.helpscout.net/conversation/2880895692/547146

viobru avatar Mar 19 '25 16:03 viobru

Related ticket: https://secure.helpscout.net/conversation/2967095439/566586?viewId=7406897

rosamillan avatar Jun 11 '25 18:06 rosamillan

Seems like this is merged in 3.20, exactly here: https://github.com/wp-media/wp-rocket/pull/7578

wordpressfan avatar Oct 08 '25 15:10 wordpressfan