Wooseung Sim
Wooseung Sim
Any updates on this issue?
+1 on this issue.
@kirangodishala Please find below the response of `/dockerRegistry/images/find` to `clouddriver-ro` ``` { "label": "find", "name": "dockerRegistry", "profiles": [ "images" ], "propertySources": [ { "name": "vault:", "source": { "artifacts.github.accounts[0].name": "github-ns", "artifacts.github.accounts[0].token":...
@kirangodishala Found my `clouddriver` custom build excluded `clouddriver-docker` project by https://github.com/spinnaker/spinnaker/blob/main/clouddriver/settings.gradle#L41. As I don't use `titus` and `cloudfoundry` my build excluded them and it lead exclude `clouddriver-docker`. However, still there...
+1 on this PR, and waiting it to be merged and released.
@mumoshu , @rentziass , @toast-gear can we get eyes from any of code owners please? I really need overriding `docker:dind` image to our internal docker registry badly due to API...
@kirangodishala I could reproduce the issue with different plugin, `com.coravy.hudson.plugins.github.GithubProjectProperty` BTW, isn't it expected to exclude all properties except `parameterDefinition` by here? https://github.com/spinnaker/spinnaker/blob/f35e148433b80e2b55d144d9ba6c95c5d86a59a5/igor/igor-web/src/main/groovy/com/netflix/spinnaker/igor/jenkins/client/JenkinsClient.groovy#L102-L103 ``` @GET('job/{jobName}/api/xml?exclude=/*/action&exclude=/*/build&exclude=/*/property[not(parameterDefinition)]') Call getJobConfig(@Path(value = 'jobName', encoded...
Indeed it takes only first query parameter if there are multiple query parameters with same key. When I switched order like below, ``` @GET('job/{jobName}/api/xml?exclude=/*/property[not(parameterDefinition)]&exclude=/*/action&exclude=/*/build') ``` It worked for the job...
Though I'm not expert on Java, seems like below kork code causing the issue. https://github.com/spinnaker/spinnaker/blob/f35e148433b80e2b55d144d9ba6c95c5d86a59a5/kork/kork-web/src/main/java/com/netflix/spinnaker/okhttp/Retrofit2EncodeCorrectionInterceptor.java#L77 ``` // Decode and encode the query parameters to correct the partial encoding done by...