feat(chart): refactor helm chart

[norman-zon]

The reactions and follow up discussion in #3216 seemed to signal users are interested in a design for the helm chart, where pod configuration is done using extra... values, instead of the template.spec approach. I understand the design decision for the current implementation, but wanted to provide an alternative.

[wooseung-sim]

+1 on this PR, and waiting it to be merged and released.

[wooseung-sim]

@mumoshu , @rentziass , @toast-gear can we get eyes from any of code owners please? I really need overriding docker:dind image to our internal docker registry badly due to API rate limit issue of docker hub.

[ronghua]

This feature is helpful. Can we get this reviewed and merged please?

[poet038]

Also a support for imagePullSecrets in the helm chart would be helpful. Regarding #2808 a registry mirror would be a solution to possible rate limits pulling the docker-in-docker image when using containerType 'dind'. Passing a Secret to the chart in order to make it possible to pull dind from a private registry would solve this as well. Are there any updates on this?

[norman-zon]

@poet038 , I just added support for imagePullSecrets.

@mumoshu , can you please start the review for this PR?

[cpotter302]

@norman-zon thanks for the quick reply. I have a small addition that would be really nice to have as well. What i can see from now is that every runner pod pulls the container images again from dockerhub. Like using imagePullPolicy 'always'. Making the pullPolicy configurable would also decrease the number of pulls and could fasten up the pod creation thus achieving a faster built time for each github workflow executed on a self-hosted runnner.

[norman-zon]

@cpotter302 pulling always is the default for image tag latest.

I don't know if setting imagePullPolicy to override this behaviour is good practice, or if you rather should pin the tag.

[rafaelgaspar]

Any updates on this getting merged?

We need to inject daemon.json into docker dind container to enable IPv6 support on an IPv6-only cluster, and currently not even using the spec works, not even resources gets added to dind container, only runner container seams to be customizable ATM.

[SharifiFaranak]

any updates on this? 🙏 related to https://github.com/actions/actions-runner-controller/issues/3709#issuecomment-2688803649

cc: @mumoshu , @rentziass , @toast-gear, @Link-

[FearlessHyena]

Can we please get this merged so #3709 can be supported 🙏

@Link- @nikola-jokic @rentziass

[cpotter302]

Any updates here?

[kohbis]

any updates on this?

[nikola-jokic]

Hey everyone,

Even though the approach looks great, we are not yet ready to merge and support it. For a change of this magnitude would require:

• All users to rewrite their values.yaml file.
• Us to update all the docs and supporting resources.
• Us to properly test these changes on many environments.

At this time, we cannot prioritize this work. Hopefully, we will get to it soon, but I cannot promise anything. Although this approach is much better (especially for containerMode kubernetes), the way it is currently working is not blocking anyone.