wolfy1339

Results 491 comments of wolfy1339

You are using CJS and not ESM. You will need to use dynamic imports or upgrade to ESM ``` "target": "es2022", "module": "node16", "moduleResolution": "node16", ```

You can use dynamic imports, upgrade your code to ESM, or stick with v5 Option 1: ```js async function main() { const { Octokit } = await import('@octokit/core'); const octokit...

From how I interpret the documentation, `default` doesn't seem needed. It should match `import` Even with the `default`, it would still error as it's ESM and people are trying to...

> Is there a specific reason _not_ to include a fallback? What led me here to begin with is seeing this issue with `tsx` after upgrading `@octokit/core`, and adding `default`...

I just released a new version with the fix as described by @jeremy-daley-kr Please open up a new issue if you still have issues.

Nope it is not CJS. You haven't defined your file as an ESM module. Either use the `.mjs` extension or specify `"type": "module"` in your `package.json`

There's a merge conflict, and I haven't gotten around to fixing it

Copying over discussion on the tests: ---- > > @octokit/js Is anyone able to figure out how to get the test passing? > > Is there a way to get...

Increasing the test timeout reveals that for some reason, the webhook payload is taking longer than 9s to be parsed, validated and event dispatched. `AssertionError: expected 'still processing\n' to deeply...

I ended up switching to nock, and it works right out of the box