auth-token.js icon indicating copy to clipboard operation
auth-token.js copied to clipboard
verified publisher icon octokit

build(deps): replace `@gr2m/fetch-mock` with `fetch-mock`

Open wolfy1339 opened this issue 1 year ago • 1 comments

Before the change?

  • Used a custom fork of fetch-mock for Fetch API support

After the change?

  • Use the fetch-mock module again, it has been updated to support the Fetch API

Pull request checklist

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • [ ] Yes
  • [ ] No

wolfy1339 avatar Jul 02 '24 01:07 wolfy1339

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

github-actions[bot] avatar Jul 02 '24 01:07 github-actions[bot]

@wolfy1339

Why dont you merge it?

Uzlopak avatar Jul 13 '24 23:07 Uzlopak

There's a merge conflict, and I haven't gotten around to fixing it

wolfy1339 avatar Jul 14 '24 00:07 wolfy1339

Should I create a new PR so that you can approve it and merge it?

Uzlopak avatar Jul 14 '24 10:07 Uzlopak

:tada: This PR is included in version 5.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Jan 27 '25 17:01 github-actions[bot]