wolfy1339

Results 491 comments of wolfy1339

> Quick question @wolfy1339, is the entity with number `267` a PR or an Issue??? That would be a PR

Can you share your node and npm versions? There seems to be recurring issues with private keys, see also #450

I would still like to get to the bottom of why it isn't working on earlier versions of Node as we still support them.

For deno support it is recommended to use esm.sh ```ts import { createAppAuth } from "https://esm.sh/@octokit/[email protected]"; ``` Out of the box support just isn't available, yet.

Is the issue still present if you use Octokit itself and not vite? You need to use the browser build of Octokit from ESM.sh with Vite for it to work...

It should be OK to start testing, I believe that we wanted to land #2137 before doing a final release

> `pkg-conf` has been renamed to `package-config`. Could you please update the dep as well? Should be a 1 line change > > [sindresorhus/package-config@ee366eb](https://github.com/sindresorhus/package-config/commit/ee366eb96eaf607cb7d18111ea98dec282f757a7) That has already been done as...

> Basically probot needs only 800 kb when bundled with esbuild (bundle does not work, lol). Why doesn't it work in a bundle?

Do you mind creating an issue for that with the configuration used so we can make sure there is nothing broken on our side, and at least document this

Can you share details on your environment? We've seen reports of some implementations not following the specifications, and returning the status code as a string instead of a number