Jason Song

Results 15 comments of Jason Song

@elazarl If there is any problem with how to set version to the submodule, you can find how "golang/tools" do it: https://github.com/golang/tools/tags Semantic versioning is so important for go modules,...

Same problem when using [protoc-gen-validate](https://github.com/envoyproxy/protoc-gen-validate), any update? ``` DomainKind kind = 11 [(validate.rules).enum = {in: [1,2,3]}]; ``` ![image](https://user-images.githubusercontent.com/9418365/119790419-7fd05200-bf06-11eb-8180-8ee9787f150c.png)

好问题哈。是这样的,代码中一共有两处有意消耗内存,一处是这里: https://github.com/wolfogre/go-pprof-practice/blob/8ce266a210ee29c5f5ae7be4fc56c5d43379670f/animal/muridae/mouse/mouse.go#L46-L52 可以看到这里的逻辑是占上 不超过 1G 内存,所以 pprof 查到 1G 内存是符合预期的。 另一处是这里: https://github.com/wolfogre/go-pprof-practice/blob/8ce266a210ee29c5f5ae7be4fc56c5d43379670f/animal/canidae/dog/dog.go#L41-L44 这里故意申请 16M 内存并立即丢弃,这里本意是为了模拟一个频繁 GC 问题,因为上文已经占了 1G 内存不放,所以 golang 每次 GC 结束,会发现还占用了 1G,所以 GC 策略会在下次内存占用超过 1G * 2 时(具体为什么是两倍可以看下...

这个问题很有价值,我复制到博客的评论里哈。

Sorry, I'm afraid I need to reserve my opinion. I don't see a strong reason to include `=` in the label name in your case. For most command tools, `a=b=c`...

> @wolfogre Please re-review. I take a neutral stance on this. Please ignore my change request and let other maintainers decide.

Maybe we could support registering the same runner to multiple org/user/repo, something like `./act_runner register add` , and the runner could fetch tasks from them simultaneously. It requires a little...

> ... I'd object to making it required, ... Sure, it's optional. Runners can skip the wait and go straight to regular polling when: - Gitea or reverse proxy does't...