goproxy
goproxy copied to clipboard
Proposal: Please start using Semantic Versioning
I found that this project already supports Go modules. But sadly, the tags doesn't follow Semantic Versioning, which means that all tags of this project will be ignored by Go modules and replaced by pseudo-versions, go get
acts weirdly when tags are not in that form. It would be great to have the tagged release be named in the format vX.X.X format so that go mod can read it.
github.com/elazarl/goproxy v0.0.0-20200710112657-153946a5f232
Else the mod file shows something like github.com/elazarl/goproxy v0.0.0-20200710112657-153946a5f232
which is not very readable and difficult to upgrade. It’s hard to verify which version is in use. This is not conducive to version control
So, I propose this project to follow Semantic Versioning in future versions. For example, v1.0.1
, v2.0.0
, v3.1.0-alpha
, v3.1.0-beta.2
etc.
@kimor79 @n-i-x Could you help me review this issue? Thx :p
Sounds great to me. This project predates go modules, and tags were supposed to support some primitive versioning by HTTP redirect. There were times...
@elazarl Thank you for your reply and look forward to a new version for module. : D
@KateGo520 can you help me with how to set version to the submodule ext/
?
@elazarl If there is any problem with how to set version to the submodule, you can find how "golang/tools" do it: https://github.com/golang/tools/tags
Semantic versioning is so important for go modules, sorry to trouble you but could you please speed this up?
Given how actively supported and widely adopted this project seems to be, I'd love to see some semantic versioning. It does make for a more ergonomic experience, as well as it deliver a sense of "craftmanship" superior to go.mod
lines like:
github.com/elazarl/goproxy v0.0.0-20220328115640-894aeddb713e
So, big support for this issue.
@detro sounds a very good idea.
Hey @elazarl are you looking for a contribution to do this or am I missing something? :)
@detro a PR would be awesome. I'm unfotunately very limited in the time I can invest, but I'm happy to review and merge PRs.
This one probably cannot be covered via PRs @elazarl , the tag injection is done directly via git tag -commands as far as I'm aware, so someone with repo write access could do it.