Kenny Wong

Results 36 comments of Kenny Wong

I am not too familiar with the fraction components for pH in terms of what is commonly used by other organization/states for analysis. Was "suspended" recently added as an allowable...

This could be an item I am interested in. I will review the current function and the requested enhancement idea in this request!

Waiting to see if checks go through successfully. Once it is successful, checking a few other examples to make sure the TADA_GroupedScatterplot is still functioning would be good to do.

> The changes to the grouped scatterplot are excellent- code is much more concise and it functions as intended. > > For viewing the color palette, the updates work for...

It seems like that error may show up depending on the screen margin of the monitor it is being viewed on. On my second monitor I don't get any error...

I am also trying to take a look into this. I ran TADA_FindPotentialDuplicatesMultipleOrgs and TADA_FindPotentialDuplicatesSingleOrg with the 1st df example. The number of rows increased only for TADA_FindPotentialDuplicatesMultipleOrgs in which...

Values of logical values of NA were found in .data for TADA.MonitoringLocationIdentifier whereas values in dupsdat for TADA.MonitoringLocationIdentifier were character "NA". > typeof(dupsdat$TADA.MonitoringLocationIdentifier) [1] "character" > df_nearby_sites_test typeof(df_nearby_sites_test$TADA.MonitoringLocationIdentifier) [1] "logical"...

Attempted to put a legend title in the plot, but it shows up to the left of the legend labels. Did try to spend some time to make it show...

#507 I believe I pushed that commit through with that small code update to this branch

Are there other examples of conversions that should be considered? Is the conversion for salinity adjustment something that would be of interest to convert?