Kenny Wong

I can work on running some random data sets. I think it would be good practice for me to run RandomTestingData and familiar myself with TADA_CreateUnitRef and harmonize data functionalities

Are we looking to convert all mediaType = Freshwater, where ResultMeasure.measureUnitCode is expressed as ug/kg, to UG/L in the TADA.Target.ResultMeasure.MeasureUnitCode? Are we looking to convert any other units? If a...

Is there any sort of indicator or ref table on which waterbody types would tie to freshwater vs saltwater?

What are your thoughts on where the conversion factors between mass/mass and mass/volume should take place? Are we looking to include additional rows in the WQXunitRef for this? Would this...

Discussed in 8/16 TADA team meeting - Should we allow an argument for user - TRUE/FALSE - on whether mass/mass to mass/volume should be converted? Include this in TADA_ConvertResultUnits?

Thoughts on horizontal lines to indicated depth category profile (Surface, Middle, Bottom)? Thoughts on a side by side plot for when the two characteristics may have unit values that differ,...

Both can be good, but perhaps give user the ability for a single plot or split plot argument - should consider how this will be handled in R Shiny

@hillarymarler @cristinamullin Would it make sense for test_that() in test-CriteriaComparison.R to contain any paired parameter argument (with TADA_DataRetrieval() ) options rather than run TADA_RandomTestingData() for testdat1? Or would we want...

I included tryCatch() and try() base functions to handle rerunning TADA_RandomTestingData() for testdat1 if they do not contain any paired parameters needed to run TADA_PairForCriteriaCalc. These changes have been made...

> That sounds like a great solution! Is PR #522 ready for review or are there still additional changes you would like to make first? #522 is ready for review