Billy Lynch
Billy Lynch
This sounds fine - I'll need to dig in a bit more to see how this is referenced in other places, but refactoring how this is passed around within chains...
/retest
@priyawadhwa underlying infra issues have be resolved - this is ready for review!
/assign @priyawadhwa
Looks good! Last thing is we should add a release-notes section to the PR (since I think the release tool will pick up on this) with the user facing changes.
Chatted with @chuangw6 about this a bit last week - I think we landed on a similar idea to yours @priyawadhwa! The alternative we were thinking of was allowing multiple...
> Is squash commits set up for this repository? Github should be able to squash the commits itself. That may be easier since the upstream and POC commits have been...
@chuangw6 what version of cosign are you using? I think https://github.com/sigstore/sigstore/commit/21bce79303a006ad3abd26c368ba3946061d6679 fixes this, and was added to cosign in v0.10.0 The `gcpkms:/` behavior looks like cosign trying to interpret the...
This sounds very similar to https://github.com/sigstore/cosign/issues/1654. Will do a bit more digging before I mark this as a dupe.
What version of cosign did you notice this in? 👀