chains icon indicating copy to clipboard operation
chains copied to clipboard

Proof of Concept for TEP-84

Open lcarva opened this issue 2 years ago • 12 comments

TEP-84 calls for end-to-end provenance collection.

In this POC, Chains is modified to attest PipelineRun resources in addition to TaskRun resources. Three new options are added to the configuration:

  • artifacts.pipelinerun.format: The format of the attestation. tekton is the default value and, similarly to artifacts.taskrun.format, it's simply the json representation of the resource itself. in-toto is also partially supported. Further work is needed to convert a PipelineRun resource into https://slsa.dev/provenance/v0.2. (Suggestions please!)
  • artifacts.pipelinerun.storage: The place where the attestation will be stored. tekton, the default value, causes attestation to be attached to an annotation on the PipelineRun resource, also similarly to artifacts.taskrun.storage. oci is also supported causing the attestation to be pushed to the corresponding OCI registry.
  • artifacts.pipelinerun.signer. Just like artifacts.taskrun.signer

Type hinting is used for determining the attestation subjects. For PipelineRun attestations, chains relies on the PipelineRun results.

This is a POC meant to gather feedback from the community before proceeding further.

lcarva avatar May 02 '22 15:05 lcarva

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: lcarva / name: Luiz Carvalho (5e926934e52dc01c5a9b102d6d1a9eaa757026f2, 459898acb742b67c710910d08ed3146ddfa56a69)
  • :white_check_mark: login: bcaton85 / name: Brandon Caton (2e08ef2a10a4f31e6efbc483cf380957d9a08197, db8f10e40ae8176176c3c9f8a7c16a1e6c42840f)

Hi @lcarva. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar May 02 '22 15:05 tekton-robot

Just wanted to bring another TEP 109 that's related to this. There are 2 things in scope related to TEP 84: 1. type hinting extended to structured results and params (this should also be considered for PipelineRun) 2. I'm trying to categorize singable targets into inputs / outputs in that TEP in the scope of TaskRun. (if this is making sense in TaskRun, then it probably also makes sense in PipelineRun)

ywluogg avatar May 05 '22 17:05 ywluogg

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: lcarva / name: Luiz Carvalho (5e926934e52dc01c5a9b102d6d1a9eaa757026f2, 459898acb742b67c710910d08ed3146ddfa56a69, 22c53240c63814848e2a22ee1a9e7f657ab5f149, 60060abc1c20dc2828d747608d700bad554d11d8, 103caa9dd0c4d7908ca3c1dd14fdb4a69bb3d94a, f5737cb84c3f213220603645b0fc39b6aaf526f1, 04394675aa743fbfb52b547c6ec81f835f912f07, b3cef805cd6521e934b5ea4e38504817d508d5d1, 427fcf89b9308b69b90fead66f86af5db03d5d4e, 26f221fbb50819a118f262ec18d8e2e0bb90aec9)
  • :white_check_mark: login: bcaton85 / name: Brandon Caton (2e08ef2a10a4f31e6efbc483cf380957d9a08197, db8f10e40ae8176176c3c9f8a7c16a1e6c42840f, 44ddfcf982c020cd12de81b677b21bf09d40654e, 1550819c190ef0cecba2a77847c20b6836bbbb06, d31455c64994196223bfae97a7cfe681cf10cad5, bd8ee797742b584a08d07a158737e7f1f1fa81d0)

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: zregvart / name: Zoran Regvart (fdf94d38b7c55d1bdf366215798f709bbb6ae2d2, 9167af877b308d6ce800ec40b167cbcc5650cbef, 6ea8ca6215fe3f0b1d83f1dca835ca7a393adea6, d62085a15e04835b5d7d2b9e7c529c023123b82e, 70677c3b30b1ad5395872a4470d2f703fbcb3759)
  • :white_check_mark: login: lcarva / name: Luiz Carvalho (a847d3a06a4bdedea040ed62bd11a1f1d9011d82, bb5f7daea0f92defc4fb11170be7b41ebd87e0f3, 81477f69e9a62a805865047142e2de742ddaacb8, 19fb4d8e3618bba99c4eb7c1996dcd0788efeec7, fdeb5f199ed4b8293def53e3308f0977bfc06064, 46a9fcc1a6ec8460bb16796fd6d83f15e2197c4d, a575ac2cb70b5b81aaa78b9497b352f08f5b9242, 9a1e7baa7735e1996e8d11b69cba574b9c6496f5, e27ba3a578b8a6f0785bfba1380f4270f50dc699, 0a22ddaec09c4bc4a8b987a6538cc7849667ef24, abf66a88e1d0497bcd751de7c3dd0e077766a56e)
  • :white_check_mark: login: bcaton85 / name: Brandon Caton (6346dd1e31b2de91e9499e4c6ec962e496ca7cab, 3945a0cd57d2a3775a2c03ca4ada6fb4a8aebd97, 67fc0ae43fbfbc6b670ac0fc287357e1bfee875a, 2342662a0d245d330d496627beb7d94b9669d0e7, 19104538ebec7757aecd0868f29ee54680f5840a)

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.3% 61.6% -7.7
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 86.4% 85.7% -0.6
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 75.6%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 73.1%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 78.9% 78.2% -0.7
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.4% 0.8
pkg/chains/storage/pubsub/pubsub.go 55.6% 57.1% 1.6
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.0% -0.0
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 73.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Jun 07 '22 17:06 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.3% 61.6% -7.7
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 86.4% 85.7% -0.6
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 75.6%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 73.1%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 78.9% 78.2% -0.7
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.4% 0.8
pkg/chains/storage/pubsub/pubsub.go 55.6% 57.1% 1.6
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.0% -0.0
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 73.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Jun 07 '22 17:06 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.3% 61.6% -7.7
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 86.4% 85.7% -0.6
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 75.3%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 73.1%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 78.9% 78.2% -0.7
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.4% 0.8
pkg/chains/storage/pubsub/pubsub.go 55.6% 57.1% 1.6
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.0% -0.0
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 73.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Jun 15 '22 14:06 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 69.3% 61.6% -7.7
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 86.4% 85.7% -0.6
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 75.3%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 73.1%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 78.9% 78.2% -0.7
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.4% 0.8
pkg/chains/storage/pubsub/pubsub.go 55.6% 57.1% 1.6
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.0% -0.0
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 73.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Jun 21 '22 05:06 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 74.5% 68.9% -5.5
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 93.0% 85.7% -7.3
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 76.7%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 74.6%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 75.5% 75.0% -0.5
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.3% 0.7
pkg/chains/storage/pubsub/pubsub.go 55.6% 57.1% 1.6
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.0% -0.0
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 70.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Aug 29 '22 19:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 74.5% 68.9% -5.5
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 93.0% 85.7% -7.3
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 76.7%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 74.6%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 75.5% 75.0% -0.5
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.3% 0.7
pkg/chains/storage/pubsub/pubsub.go 55.6% 57.1% 1.6
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.0% -0.0
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 70.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Aug 29 '22 21:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 74.5% 68.9% -5.5
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 93.0% 85.7% -7.3
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 76.7%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 74.6%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 75.5% 75.0% -0.5
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.3% 0.7
pkg/chains/storage/pubsub/pubsub.go 55.6% 57.1% 1.6
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.0% -0.0
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 70.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Aug 30 '22 14:08 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 74.5% 68.9% -5.5
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 93.0% 85.7% -7.3
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 76.7%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 74.6%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 75.5% 75.0% -0.5
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.3% 0.7
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.6% 0.5
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 70.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Sep 01 '22 16:09 tekton-robot

/ok-to-test

chuangw6 avatar Sep 16 '22 18:09 chuangw6

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 74.5% 68.9% -5.5
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 93.0% 85.7% -7.3
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 76.7%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 74.6%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 75.5% 75.0% -0.5
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.3% 0.7
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.6% 0.5
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 70.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Sep 16 '22 20:09 tekton-robot

Is squash commits set up for this repository? Github should be able to squash the commits itself. That may be easier since the upstream and POC commits have been interweaved on the poc branch.

bcaton85 avatar Sep 20 '22 13:09 bcaton85

Is squash commits set up for this repository? Github should be able to squash the commits itself. That may be easier since the upstream and POC commits have been interweaved on the poc branch.

Squash commits are set up via prow, which unfortunately means you don't have the same control over the merge message as you would with the native GitHub merge message UI. Prow is just going to concat all 48 commit messages together into one uber message. 😭

Normally I don't think it's a big deal for a handful of commits but this is quite a lot so I think we should take the extra step to make sure are cleaned up, especially since some of the merge commits appear to reference unrelated changes like adding additional GitHub Actions workflows. 🙏

wlynch avatar Sep 20 '22 13:09 wlynch

Ahhh okay understood, let me get something together

bcaton85 avatar Sep 20 '22 13:09 bcaton85

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 74.5% 68.9% -5.5
pkg/chains/annotations.go 87.1% 82.9% -4.2
pkg/chains/formats/intotoite6/intotoite6.go 93.0% 85.7% -7.3
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 76.7%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 74.6%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 75.5% 73.4% -2.1
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.3% 0.7
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.6% 0.5
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 70.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Sep 20 '22 13:09 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 74.5% 68.9% -5.5
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 93.0% 85.7% -7.3
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 76.7%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 74.6%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 75.5% 75.0% -0.5
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.3% 0.7
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.6% 0.5
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 70.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Sep 20 '22 13:09 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 74.5% 68.9% -5.5
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 93.0% 85.7% -7.3
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 76.7%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 74.6%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 75.5% 75.0% -0.5
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.3% 0.7
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.6% 0.5
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 70.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Sep 20 '22 17:09 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 74.5% 68.9% -5.5
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 93.0% 85.7% -7.3
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 76.7%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 74.6%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 75.5% 75.0% -0.5
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.3% 0.7
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.6% 0.5
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 70.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Sep 20 '22 19:09 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 74.5% 68.9% -5.5
pkg/chains/annotations.go 87.1% 87.9% 0.8
pkg/chains/formats/intotoite6/intotoite6.go 93.0% 85.7% -7.3
pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go Do not exist 76.7%
pkg/chains/formats/intotoite6/taskrun/buildconfig.go Do not exist 100.0%
pkg/chains/formats/intotoite6/taskrun/taskrun.go Do not exist 74.6%
pkg/chains/formats/tekton/tekton.go 33.3% 28.6% -4.8
pkg/chains/rekor.go 26.9% 29.6% 2.7
pkg/chains/signing.go 75.5% 75.0% -0.5
pkg/chains/storage/gcs/gcs.go 48.4% 50.7% 2.3
pkg/chains/storage/grafeas/grafeas.go 78.6% 79.3% 0.7
pkg/chains/storage/storage.go 53.6% 56.7% 3.1
pkg/chains/storage/tekton/tekton.go 78.0% 78.6% 0.5
pkg/reconciler/pipelinerun/controller.go Do not exist 94.4%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 70.3%
pkg/reconciler/taskrun/taskrun.go 90.0% 90.9% 0.9

tekton-robot avatar Sep 20 '22 19:09 tekton-robot

Updated with squash commit.

bcaton85 avatar Sep 20 '22 20:09 bcaton85

@wlynch @chuangw6 should be good to merge, let me know if you agree.

bcaton85 avatar Sep 20 '22 20:09 bcaton85

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Sep 20 '22 20:09 tekton-robot