chains icon indicating copy to clipboard operation
chains copied to clipboard
verified publisher icon tektoncd

Make grafeas notehint configurable and change the BuildType field

Open chuangw6 opened this issue 3 years ago • 6 comments

  • Add new configmap field - storage.grafeas.notehint to allow customization for the hint field configurable in grafeas ATTESTATION Note
  • Change the BuildType field in the intoto attestation to the GroupVersionKind of the run object i.e. tekton.dev/v1beta1/kind=TaskRun
  • This commit also cleans up the testing code.

chuangw6 avatar Jul 20 '22 22:07 chuangw6

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

tekton-robot avatar Jul 20 '22 22:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/grafeas/grafeas.go 78.1% 77.5% -0.6

tekton-robot avatar Jul 22 '22 20:07 tekton-robot

/assign wlynch

chuangw6 avatar Jul 25 '22 16:07 chuangw6

Offline discussed with @wlynch.

We decided to just allow the hint field in grafeas note to be configurable.

  • The buildType in the slsa predicate of intoto attestation will be set to run object's groupversion kind.
  • The builderVersion in the grafeas build note will be set to an annotation field of the run object that will be added in pipeline. See https://github.com/tektoncd/pipeline/issues/5303 for more information.

chuangw6 avatar Aug 10 '22 15:08 chuangw6

/test pull-tekton-chains-integration-tests

chuangw6 avatar Aug 10 '22 16:08 chuangw6

Looks good! Last thing is we should add a release-notes section to the PR (since I think the release tool will pick up on this) with the user facing changes.

wlynch avatar Aug 24 '22 21:08 wlynch

Looks good! Last thing is we should add a release-notes section to the PR (since I think the release tool will pick up on this) with the user facing changes.

SG! Added!

chuangw6 avatar Aug 24 '22 21:08 chuangw6

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Aug 25 '22 21:08 tekton-robot