Weslley Alves de Oliveira

Results 14 comments of Weslley Alves de Oliveira

## Proposal ### Please re-state the problem that we are trying to solve in this issue. when adding amount details to a failed smartscan, default currency isn’t local ### What...

Hi everyone, I created the PR with the changes https://github.com/Expensify/App/pull/33853 If you have any questions or suggestions, please let me know.

Hi @aldo-expensify did you have time to execute your tests to check the better place to fix this issue? If there is something that I can help, please let me...

> I found the code in the backend where we are setting the `modifiedCurrency` when smartscan fails and it is new code that was introduced for the new app. I...

Hi @aldo-expensify if you have any questions or suggestions, please let me know.

> https://github.com/Expensify/App/actions/runs/7481248190/job/20362450408?pr=33853#step:6:85) I saw here, that I need to improve my Unit Tests because the method [areRequiredFieldsEmpty](https://github.com/Expensify/App/blob/main/src/libs/TransactionUtils.ts#L158) was changed the implementation through this commit [1aea9ac](https://github.com/wlegolas/ExpensifyApp/commit/1aea9aca269345c6ec815d0bd4977b11d6ca0fa2) I'll make the changes and...

> @wlegolas You can hold a bit on fixing the tests if you want, I wanted to explore a bit more the idea of fixing this in the backend now...

> @wlegolas Can you please merge main? Sure, I updated my branch with the `main` branch. I tested again and It seems like everything is working as expected.

Hi @parasharrajat I resolved a conflict in the `BaseInvertedFlatList` because this component was migrated to TypeScript from this Pull Request https://github.com/Expensify/App/pull/33288 If you have any questions, please let me know.

I saw the Unit Test step is failing, but this problem is occurring on the `main` branch, if I see a commit with the fix, I'll do another merge to...