Fix tapping on new messages after marking a message unread leads to a blank page

[wlegolas]

Details

This PR will fix the issue related to the displayed blank page when the user clicks on the "New messages" button before the scroll action ends.

Fixed Issues

$ https://github.com/Expensify/App/issues/31591 PROPOSAL: https://github.com/Expensify/App/issues/31591#issuecomment-1820145900

Tests

1. Navigate to https://dev.new.expensify.com:8082
2. Log in
3. Open a group conversation with a lot of messages
4. Swipe to the middle of the page and mark any message as unread
5. Swipe to the top of the page
6. Tap on the "New messages" button
7. The user is redirected to the unread message.

• [x] Verify that no errors appear in the JS console

Offline tests

1. Navigate to https://dev.new.expensify.com:8082
2. Log in
3. Open a group conversation with a lot of messages
4. Turn off your network connection
5. Swipe to the middle of the page and mark any message as unread
6. Swipe to the top of the page
7. Tap on the "New messages" button
8. The user is redirected to the unread message.

• [x] Verify that no errors appear in the JS console

QA Steps

1. Navigate to https://staging.new.expensify.com/
2. Log in
3. Open a group conversation with a lot of messages
4. Swipe to the middle of the page and mark any message as unread
5. Swipe to the top of the page
6. Tap on the "New messages" button
7. The user is redirected to the unread message.

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/698363/7ff141e2-01e0-4a17-8d13-9392bb5efd3b

Android: mWeb Chrome

https://github.com/Expensify/App/assets/698363/24a7b4cd-22b3-4d03-bc61-64cff0835730

iOS: Native

https://github.com/Expensify/App/assets/698363/e25e9884-83fb-40a2-961d-914e8a6ecb5f

iOS: mWeb Safari

https://github.com/Expensify/App/assets/698363/4d32224a-e395-4c3b-87dd-177684c82868

MacOS: Chrome / Safari

Chrome

https://github.com/Expensify/App/assets/698363/8d8691f5-5650-4090-a287-d9aeff2f9f57

Safari

https://github.com/Expensify/App/assets/698363/2d4ec831-c927-4057-a927-8254e279b2e8

MacOS: Desktop

https://github.com/Expensify/App/assets/698363/bd540e4a-a927-4106-9886-139510056c00

[melvin-bot[bot]]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[parasharrajat]

Testing...

[parasharrajat]

@wlegolas Can you please merge main?

[wlegolas]

@wlegolas Can you please merge main?

Sure, I updated my branch with the main branch. I tested again and It seems like everything is working as expected.

[parasharrajat]

Please use merge commit instead of force push. For now, we are fine on this PR.

[wlegolas]

Hi @parasharrajat I resolved a conflict in the BaseInvertedFlatList because this component was migrated to TypeScript from this Pull Request https://github.com/Expensify/App/pull/33288

If you have any questions, please let me know.

[wlegolas]

I saw the Unit Test step is failing, but this problem is occurring on the main branch, if I see a commit with the fix, I'll do another merge to check this step.

[parasharrajat]

I am not sure if we want to mimic Slack behavior. Also, this is a big decision to make. If we find this idle then we will have to propose this on Slack first.

I tested your branch and there are a few issues. I will post them here after I am done.

[wlegolas]

I am not sure if we want to mimic Slack behavior. Also, this is a big decision to make. If we find this idle then we will have to propose this on Slack first.

I tested your branch and there are a few issues. I will post them here after I am done.

I'm not trying to mimic Slack behavior, just trying to bring the behavior to the "New message" button closes that the behavior we know from Slack, but you're right, we need to propose to the Expensify team.

In my opinion, for this issue, we only need to know which is the expected result when there is a new message, I just putting this behavior because for me makes sense to show the "New message" button when there is a new message and the scroll ends.

But I'm totally open to hearing your suggestion

[parasharrajat]

Reviewing...

[wlegolas]

Hi @parasharrajat do you have updates about your review process?

[parasharrajat]

@wlegolas Please merge the main when you get time. Thanks for waiting.

[wlegolas]

@wlegolas Please merge the main when you get time. Thanks for waiting.

Hi @parasharrajat I merged the main into my branch, I did some tests and the implementation is working as expected.

If you need anything else, please let me know.

[wlegolas]

Hi @parasharrajat did you have time to review my PR?

[parasharrajat]

I have been OOO since 10 days. I was about to grt back but something came up. I will try to get this tomorrow. I started the analysis before going OOO.