W. Trevor King
W. Trevor King
“with” → “and the”, but otherwise e0a2f66 looks good to me.
f256b57f looks good to me. Maybe the “…, and …, and” would feel better to you if we use parens? > `oci-unpack` validates an application/vnd.oci.image.manifest.v1+json (and the entire Merkle tree...
On Thu, Nov 17, 2016 at 07:49:24PM -0800, Ye Yin wrote: > IMO, we should add `List` API to return all digest for `Engine > interface`, such as: > >...
On Thu, Nov 17, 2016 at 08:25:25PM -0800, Ye Yin wrote: > And more, I'd like to add `Exist` API: > > ``` > // Exist Return true if digest...
On Thu, Nov 17, 2016 at 10:46:44PM -0800, Ye Yin wrote: > IMO, `List` is a very basic API, `GC` is one case. Get all digests > is very common...
On Fri, Nov 18, 2016 at 12:20:55AM -0800, xiekeyang wrote: > Can we use `Get(ctx context.Context, desc descriptor)`, to instead > Get(ctx context.Context, digest string). I've avoided going with the...
On Fri, Nov 18, 2016 at 03:34:16AM -0800, xiekeyang wrote: > > In a later #5 commit I add blobPath [1] and refPath [2] helpers to > > abstract these...
On Fri, Nov 18, 2016 at 03:40:35AM -0800, xiekeyang wrote: > I think CAS engine interface is great, but I'm not sure that command > `oci-cas get` is useful. As...
On Fri, Nov 18, 2016 at 03:57:19AM -0800, xiekeyang wrote: > Sorry, I mean could you please squash those of `blobPath` and > `refPath` to this commit? blobPath shifted in...
On Wed, Nov 30, 2016 at 03:21:10PM -0800, Stephen Day wrote: > It doesn't have a transaction interface for verifying and setting > blobs. What sort of interface are you...