image-tools icon indicating copy to clipboard operation
image-tools copied to clipboard

description: validates manifest when unpack

Open xiekeyang opened this issue 9 years ago • 7 comments

Actually, the validation object before unpack is whole manifest schema, not only its own media type. Signed-off-by: xiekeyang [email protected]

xiekeyang avatar Oct 07 '16 03:10 xiekeyang

@wking I update it, to present the description as,

oci-unpack validates an application/vnd.oci.image.manifest.v1+json, with entire Merkle tree rooted on it, and unpacks its layered filesystem to dest.

If it is OK?

xiekeyang avatar Oct 21 '16 07:10 xiekeyang

“with” → “and the”, but otherwise e0a2f66 looks good to me.

wking avatar Oct 21 '16 07:10 wking

.@wking I change with to and the, although I fell and.., and not very smooth.

xiekeyang avatar Oct 21 '16 07:10 xiekeyang

f256b57f looks good to me. Maybe the “…, and …, and” would feel better to you if we use parens?

oci-unpack validates an application/vnd.oci.image.manifest.v1+json (and the entire Merkle tree rooted on it) and unpacks its layered filesystem to dest.

wking avatar Oct 21 '16 14:10 wking

LGTM

Approved with PullApprove

vbatts avatar Feb 14 '17 16:02 vbatts

Please rebase.

zhouhao3 avatar Jul 11 '17 06:07 zhouhao3

@xiekeyang Please rebase.

zhouhao3 avatar Sep 26 '17 06:09 zhouhao3