W. Trevor King

Results 470 comments of W. Trevor King

On Sun, Nov 09, 2014 at 03:48:14AM -0800, Max Ogden wrote: > I was thinking about taking a stab at an abstract-table-store > module, … Sounds great, but I still...

Ah. Maybe we should table this PR and pull the image -> runtime config conversion out into a helper first. Thoughts on whether we'll want to use the existing image-tools...

I've pushed 9c33abd1 → 175919c5, cleaning up `buildOCIProcessArgs`, adding support for images that do not declare either `Entrypoint` or `Cmd`, and using `buildOCIProcessArgs` in `RunPodSandbox`. The final change is what...

Anything I can do to help this along?

Anything I can do to help this along? I've just pushed a93e74349 → 7fd3de81e, rebasing onto master and fixing a lint error. Would it be easier to review if I...

Rebased onto master with 7fd3de81e -> ab3536ec1 to resolve a trivial context conflict due to #1545.

I'll take another run at this soon. See [here][1] for me whining about poor infra-image implementations. I expect runtimes will have more robust offerings, and this gets us closer to...

Rebased onto master with ab3536ec -> 59bf779e (mostly around #1655). None of the hunks changed, just the file they were located in.

All green except for Travis, which [no longer has a job log for that run][1]. [1]: https://travis-ci.org/kubernetes-sigs/cri-o/jobs/503367739

[verify][1]: ``` There was no error output from the command. [ERROR] hack/lib/cmd.sh:10: `return "${return_code}"` exited with status 1. [ERROR] hack/verify-generated.sh exited with code 1 after 00h 00m 39s ``` Not...