Will Thompson

Results 129 comments of Will Thompson

@barthalion how would this overlap with your plan to write a linter? Maybe this tool should subsume that plan.

You can also use `"//"` keys in your JSON manifest, wth the comment as a string value. These are valid JSON, explicitly ignored by `flatpak-builder`, and will be preserved by...

Got it. I agree it would be nice to preserve non-standard comments. If jsonc is de-facto compatible with what people use on Flathub (easy enough to verify if one has...

It still might be easier to have a link in the PR rather than needing to dig into the Actions tab.

The code to write manifests back supports reading format preferences from `.editorconfig` and applying them to JSON files. It seems that a `max_line_length` property [is defined](https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#supported-by-a-limited-number-of-editors). You could teach the...

Something like this except tested and passing checks and maybe not modifying global state? ```diff diff --git a/src/lib/utils.py b/src/lib/utils.py index c5f767f..1b83604 100644 --- a/src/lib/utils.py +++ b/src/lib/utils.py @@ -456,6 +456,10 @@...

The name of the branches that f-e-d-c pushes are based on the tree hash, which will change whenever the date changes, so if a PR is not merged within the...

That could work. The GitLab API for fetching a tag's metadata is unauthenticated if the repo is public: ``` $ http GET https://gitlab.gnome.org/api/v4/projects/gnome%2Fgnome-initial-setup/repository/tags/3.38.2 HTTP/1.1 200 OK Cache-Control: max-age=0, private, must-revalidate...