flatpak-external-data-checker icon indicating copy to clipboard operation
flatpak-external-data-checker copied to clipboard

Include link to GitHub Actions log in PR

Open wjt opened this issue 4 years ago • 4 comments

If a weird PR is filed, it is useful to have a look at the checker's debug output.

GitHub Actions have access to a whole host of environment variables which describe the context that the action is running in. So we should be able to build a link to the current workflow run, and include a link in the pull request message.

https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID

wjt avatar Oct 04 '21 10:10 wjt

I hope we'll move away from the shared org-wide action some day. When/if we do, I guess this feature won't be needed?

gasinvein avatar Oct 04 '21 10:10 gasinvein

It still might be easier to have a link in the PR rather than needing to dig into the Actions tab.

wjt avatar Oct 04 '21 10:10 wjt

If I understand correctly, for now, this means give a log to the hourly f-e-d-c run that triggered that PR?

So for example:

https://github.com/flathub/flathub/runs/$GITHUB_RUN_ID?check_suite_focus=true

With 4392377410 for GITHUB_RUN_ID gives:

https://github.com/flathub/flathub/runs/4392377410?check_suite_focus=true

They could also be sent to the raw logs:

https://github.com/flathub/flathub/commit/8130805a528c4bc800f3d611dfcede4cc3661000/checks/4392377410/logs

vchernin avatar Dec 02 '21 09:12 vchernin

I wasn't aware those logs were available at all and I did ask for them in #286 . Definitely add those links!

dreua avatar Jan 04 '23 00:01 dreua