flatpak-external-data-checker icon indicating copy to clipboard operation
flatpak-external-data-checker copied to clipboard
verified publisher icon flathub-infra

Fix run-in-container wrapper script and associated instructions

Open vchernin opened this issue 3 years ago • 6 comments

The container image was adapted for local use in 064fdeaa85e00bf72832d1991a571b4e009137ae, which means the default entrypoint is f-e-d-c itself. However, test suites from CONTRIBUTING.md don't run, since they need to be run from python3 normally. So fix by setting entrypoint to python3 in the run-in-container wrapper script.

Black was removed since it is run by CI and no longer present in the image, and should be easy to install in a Toolbox or elsewhere.

vchernin avatar Feb 10 '22 01:02 vchernin

I have been using this for my important source PR, it works as intended, even if a bit hacky

vchernin avatar Apr 30 '22 07:04 vchernin

Honestly, I'm not sure why we need this wrapper script at all. Running fedc with podman directly seems easy enough to me. Lets ask @wjt opinion.

gasinvein avatar Apr 30 '22 08:04 gasinvein

I am not attached to this script.

wjt avatar Apr 30 '22 16:04 wjt

@wjt I suppose Endless doesn't need it on its CI anymore (IIRC it did)?

gasinvein avatar Apr 30 '22 21:04 gasinvein

No, all that is long gone.

wjt avatar May 01 '22 18:05 wjt

Stumbled back upon this. At this point I think the wrapper script is actively misleading and I guess we should kill it and update the documentation. But I did find its old usage useful for local development…

wjt avatar Nov 08 '23 11:11 wjt