Yiding Cui
Yiding Cui
Seems that the effect of this pull is more than we expected. https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fghpr_unit_test/detail/ghpr_unit_test/12315/tests From the output, some tests were panicked after this patch.
ex里站的 api 更新了？其他的 Android app 也寄了
And for the memory allocation mentioned by @0xPoe Seems that the allocation is coming from ``` getComparedBytes = func(datum types.Datum) ([]byte, error) { encoded, err := codec.EncodeKey(ctx.GetSessionVars().StmtCtx.TimeZone(), nil, datum) err...
/hold
@dash12653 Hi, you need to also update the test result. Follow the below step: - Use `make` to create binary. - Go to `tests/integrationtest` - run `./run-tests.sh -s ../../bin/tidb-server -r...
Thanks! I'll check whether the tests all are green and help to merge this pull request.
/retest
I want this pull to get at least three LGTM. So add the hold label to make sure that it would not be merged accidentally.
Multi-table delete's change will be added soon.
 FK is checked before the `recordSet.Close()` is called. I think it's a very reasonable behavior. So the single table delete case also needs to set and reset the extra...