pingcap
planner: polish the pr #64768
What problem does this PR solve?
Issue Number: ref #64651
Problem Summary:
What changed and how does it work?
Because that pr was merged for some urgent needs, this pr is to address comments in that pr.
Check List
Tests
- [x] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
- [ ] I checked and no code files have been changed.
Side effects
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility
Documentation
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
None
Codecov Report
:x: Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 70.8307%. Comparing base (2d2bd57) to head (7144b59).
:warning: Report is 35 commits behind head on feature/fts.
Additional details and impacted files
@@ Coverage Diff @@
## feature/fts #64995 +/- ##
===================================================
- Coverage 72.3094% 70.8307% -1.4787%
===================================================
Files 1895 1873 -22
Lines 533272 525578 -7694
===================================================
- Hits 385606 372271 -13335
- Misses 123717 130835 +7118
+ Partials 23949 22472 -1477
| Flag | Coverage Δ | |
|---|---|---|
| integration | 40.0626% <15.7894%> (-6.2167%) |
:arrow_down: |
| unit | 69.9243% <86.8421%> (+0.0403%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| dumpling | 52.8700% <ø> (ø) |
|
| parser | ∅ <ø> (∅) |
|
| br | 46.2685% <ø> (-16.7702%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@hawkingrei: The /test command needs one or more targets.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-sqllogic-test
/test pull-tiflash-integration-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:
/test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
@hawkingrei: No presubmit jobs available for pingcap/tidb@feature/fts
In response to this:
/test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![tiprow[bot] avatar](https://avatars.githubusercontent.com/in/18927?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ti-chi-bot[bot]: No presubmit jobs available for pingcap/tidb@feature/fts
In response to this:
@hawkingrei: The
/testcommand needs one or more targets. The following commands are available to trigger required jobs:/test build/test check-dev/test check-dev2/test mysql-test/test pull-br-integration-test/test pull-integration-ddl-test/test pull-integration-e2e-test/test pull-lightning-integration-test/test pull-mysql-client-test/test pull-unit-test-ddlv1/test unit-testThe following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test/test pull-common-test/test pull-e2e-test/test pull-integration-common-test/test pull-integration-copr-test/test pull-integration-jdbc-test/test pull-integration-mysql-test/test pull-integration-nodejs-test/test pull-integration-python-orm-test/test pull-sqllogic-test/test pull-tiflash-integration-testUse
/test allto run the following jobs that were automatically triggered:pingcap/tidb/ghpr_buildpingcap/tidb/ghpr_checkpingcap/tidb/ghpr_check2pingcap/tidb/ghpr_mysql_testpingcap/tidb/ghpr_unit_testpingcap/tidb/pull_integration_ddl_testpingcap/tidb/pull_integration_e2e_testpingcap/tidb/pull_mysql_client_testIn response to this:
/test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@hawkingrei: No presubmit jobs available for pingcap/tidb@feature/fts
In response to this:
/test fast_test_tiprow_for_release
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ti-chi-bot[bot]: No presubmit jobs available for pingcap/tidb@feature/fts
In response to this:
@hawkingrei: The specified target(s) for
/testwere not found. The following commands are available to trigger required jobs:/test build/test check-dev/test check-dev2/test mysql-test/test pull-br-integration-test/test pull-integration-ddl-test/test pull-integration-e2e-test/test pull-lightning-integration-test/test pull-mysql-client-test/test pull-unit-test-ddlv1/test unit-testThe following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test/test pull-common-test/test pull-e2e-test/test pull-integration-common-test/test pull-integration-copr-test/test pull-integration-jdbc-test/test pull-integration-mysql-test/test pull-integration-nodejs-test/test pull-integration-python-orm-test/test pull-sqllogic-test/test pull-tiflash-integration-testUse
/test allto run the following jobs that were automatically triggered:pingcap/tidb/ghpr_buildpingcap/tidb/ghpr_checkpingcap/tidb/ghpr_check2pingcap/tidb/ghpr_mysql_testpingcap/tidb/ghpr_unit_testpingcap/tidb/pull_integration_ddl_testpingcap/tidb/pull_integration_e2e_testpingcap/tidb/pull_mysql_client_testIn response to this:
/test fast_test_tiprow_for_release
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@hawkingrei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-sqllogic-test
/test pull-tiflash-integration-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:
/test fast_test_tiprow_for_release
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@hawkingrei: No presubmit jobs available for pingcap/tidb@feature/fts
In response to this:
/test fast_test_tiprow_for_release
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ti-chi-bot[bot]: No presubmit jobs available for pingcap/tidb@feature/fts
In response to this:
@hawkingrei: The specified target(s) for
/testwere not found. The following commands are available to trigger required jobs:/test build/test check-dev/test check-dev2/test mysql-test/test pull-br-integration-test/test pull-integration-ddl-test/test pull-integration-e2e-test/test pull-lightning-integration-test/test pull-mysql-client-test/test pull-unit-test-ddlv1/test unit-testThe following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test/test pull-common-test/test pull-e2e-test/test pull-integration-common-test/test pull-integration-copr-test/test pull-integration-jdbc-test/test pull-integration-mysql-test/test pull-integration-nodejs-test/test pull-integration-python-orm-test/test pull-sqllogic-test/test pull-tiflash-integration-testUse
/test allto run the following jobs that were automatically triggered:pingcap/tidb/ghpr_buildpingcap/tidb/ghpr_checkpingcap/tidb/ghpr_check2pingcap/tidb/ghpr_mysql_testpingcap/tidb/ghpr_unit_testpingcap/tidb/pull_integration_ddl_testpingcap/tidb/pull_integration_e2e_testpingcap/tidb/pull_mysql_client_testIn response to this:
/test fast_test_tiprow_for_release
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AilinKid, time-and-fate
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/planner/OWNERS~~ [AilinKid,time-and-fate]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
2025-12-16 09:38:06.249291785 +0000 UTC m=+1552231.063069347: :ballot_box_with_check: agreed by time-and-fate.2025-12-22 06:23:52.298747282 +0000 UTC m=+2058977.112524854: :ballot_box_with_check: agreed by AilinKid.