planner: optimize bucket collection

[ichen032]

What problem does this PR solve?

Issue Number: close #61738

Problem Summary:

What changed and how does it work?

Check List

Tests

• [x] Unit test
• [ ] Integration test
• [ ] Manual test (add detailed scripts or steps below)
• [ ] No need to test

  • [ ] I checked and no code files have been changed.

Side effects

• [ ] Performance regression: Consumes more CPU
• [ ] Performance regression: Consumes more Memory
• [ ] Breaking backward compatibility

Documentation

• [ ] Affects user behaviors
• [ ] Contains syntax changes
• [ ] Contains variable changes
• [ ] Contains experimental features
• [ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot[bot]]

Welcome @ichen032!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. :smiley:

[ti-chi-bot[bot]]

Hi @ichen032. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pingcap-cla-assistant[bot]]

All committers have signed the CLA.

[tiprow[bot]]

Hi @ichen032. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[terry1purcell]

/ok-to-test

[codecov[bot]]

Codecov Report

:x: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 73.1964%. Comparing base (f46112d) to head (516bb80). :warning: Report is 416 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #61714        +/-   ##
================================================
+ Coverage   73.1012%   73.1964%   +0.0951%     
================================================
  Files          1730       1782        +52     
  Lines        481253     516021     +34768     
================================================
+ Hits         351802     377709     +25907     
- Misses       107913     115557      +7644     
- Partials      21538      22755      +1217     

Flag	Coverage Δ
integration	45.1210% <72.7272%> (?)
unit	72.2046% <72.7272%> (-0.1378%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7804% <ø> (ø)
parser	∅ <ø> (∅)
br	44.5715% <ø> (-2.3945%)	:arrow_down:

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[terry1purcell]

/hold

[terry1purcell]

/retest-required

[ichen032]

/retest

[ti-chi-bot[bot]]

@ichen032: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-integration-e2e-test-next-gen	6bbc3ed7c609a9a20b620e29208722140507efbb	link	false	/test pull-integration-e2e-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[winoros]

And for the memory allocation mentioned by @0xPoe Seems that the allocation is coming from

		getComparedBytes = func(datum types.Datum) ([]byte, error) {
			encoded, err := codec.EncodeKey(ctx.GetSessionVars().StmtCtx.TimeZone(), nil, datum)
			err = ctx.GetSessionVars().StmtCtx.HandleError(err)
			if memTracker != nil {
				// tmp memory usage
				deltaSize := int64(cap(encoded))
				memTracker.BufferedConsume(&bufferedMemSize, deltaSize)
				memTracker.BufferedRelease(&bufferedReleaseSize, deltaSize)
			}
			return encoded, err
		}

So we can use a byte slice buffer to reduce the memory usage. Then I think there will be no regression anymore.

The second param of the EncodeKey is just the buffer. I think the diff size is limited.

But if this makes the pr too large. The changes can be split into an individual pr.

The general idea LGTM🥰

[ti-chi-bot[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign time-and-fate for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/statistics/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[ichen032]

/retest-required

[ichen032]

/retest-required

[tiprow[bot]]

@ichen032: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tidb_parser_test	516bb8082a9a8f430321ccb81f8c24756e0b805b	link	true	/test tidb_parser_test
fast_test_tiprow	516bb8082a9a8f430321ccb81f8c24756e0b805b	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.