Wing

Results 16 comments of Wing

> lgtm, solid work. It seems Chrome supports them now: > > https://developer.chrome.com/blog/early-hints/ > > Could you add them to HTTP/2 too? Or it would be better to do it...

> Also what should happen when neither a string nor array is passed in? Is a 103 without headers permitted? Should we throw an exception? Either way we should also...

> What should happen if the array is empty? Could you add a test for this case? @mcollina I think there will be scenarios where we want to create a...

> minor nit: perhaps we could consolidate the tests into one file for this new feature? > > Additionally we should test that the function throws when it should. @mscdex...

> The first commit in PR should start with affected sybsystem, which is `http` (`src` mostly refers to generic changes in C++ parts of code). This can be fixed by...

> LGTM, thanks a lot for your contribution! > > For reference, the contents of this `Link` header are described in RFC 8288, [B.2.](https://httpwg.org/specs/rfc8288.html#rfc.section.B.2) [Parsing a Link Field Value](https://httpwg.org/specs/rfc8288.html#parse-fv) in...

> > lgtm, solid work. It seems Chrome supports them now: > > https://developer.chrome.com/blog/early-hints/ > > Could you add them to HTTP/2 too? Or it would be better to do...

> lgtm > > Amazing work! > > I think you should add to the docs in https://nodejs.org/api/http2.html#class-http2http2serverresponse too done! 👉 https://github.com/nodejs/node/pull/44180/files#diff-f63531002261f56a8c6723723d2b7e6d05ea9ec8d433195fdf7c47728f6e3700

> If the spec allows any header I would make it simple and only use a kvp object. I think `validateHeaderName()` and `validateHeaderValue()` from `_http_outgoing.js` can be used to validate...

@anton-karlovskiy since the new commits use the `supported` property I've changed the `unsupported` properties from the other hooks to `supported`