react-adaptive-hooks icon indicating copy to clipboard operation
react-adaptive-hooks copied to clipboard

Published 20 hours ago • verified publisher icon GoogleChromeLabs

some suggestions to unify code

Open wingleung opened this issue 5 years ago • 5 comments

kicking off #37

wondering if we could change the api response to return a supported property instead of the existing unsupported property. If we change it to supported there is no double negatives confusion.

wingleung avatar Dec 23 '19 15:12 wingleung

@wingleung cc @addyosmani

Overall the optimization looks good to me. I think we could reduce the number of lines of code.

@wingleung Could you please check my comments?

anton-karlovskiy avatar Mar 10 '20 20:03 anton-karlovskiy

@anton-karlovskiy since the new commits use the supported property I've changed the unsupported properties from the other hooks to supported

wingleung avatar Mar 11 '20 18:03 wingleung

since the new commits use the supported property I've changed the unsupported properties from the other hooks to supported

That sounds good to me. But first let's ask @addyosmani.

anton-karlovskiy avatar Mar 11 '20 20:03 anton-karlovskiy

@wingleung

There are conflicting files.

anton-karlovskiy avatar Mar 20 '20 23:03 anton-karlovskiy

@anton-karlovskiy thanks for the heads up, merge conflicts resolved

wingleung avatar Mar 21 '20 07:03 wingleung