William Cheng

Results 983 comments of William Cheng

closed via https://github.com/OpenAPITools/openapi-generator/pull/19830 thanks for the contribution

thanks for the PR. i've filed https://github.com/OpenAPITools/openapi-generator/pull/18720 based on your PR with updated samples. all tests passed. if no further feedback, I'll merge this PR later this week. cc @devhl-labs

https://github.com/OpenAPITools/openapi-generator/milestones you can use customized templates (e.g. -t via CLI) for the time being

can you please file a PR to start with? ``` oneOf: - type: string - type: number - type: integer - type: boolean - type: array items: type: object -...

> I've been using the openapi generation for years. I tend to generate python and javascript client libraries. happy to hear that you've been using it for years :)

yes, that's the mustache file you will need to update.

Would you like to sponsor the fix? If I remember correctly, the oneOf implementation in JS client was also sponsored (and I was the one coming up with the implementation)

i've merged a PR to simply any type represented by oneOf/anyOf: https://github.com/OpenAPITools/openapi-generator/pull/18268 can you give it a try with the latest master (snapshot version can be found in readme)?

would you like to contribute a PR to support it? https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AspNetServerCodegen.java#L187 is a good starting point.

thanks for opening an issue to track this for option 2, personally it's not something i prefer. for option 1, i think `convertPropertyToBooleanAndWriteBack` is used in many generators already so...