William Cheng

Results 983 comments of William Cheng

thanks for the PR can you please update the samples as well as requested in step 3 of the PR checklist? cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02)...

thanks for the PR. can you please PM me via Slack when you've time? https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

can you please file a new one without updating the samples? i'll update the samples based on your new PR

https://github.com/OpenAPITools/openapi-generator/actions/runs/9119392437/job/25147922695?pr=18692 can you please take a look at the test failure when you've time?

thanks for the PR. let's give it a try

> @OpenAPITools/generator-core-team Is there a precedent where the Codegen class will generate an error depending on the contents of the spec? We seldom do that. Sometimes we throw warnings to...

@dkliban Your suggested fix looks like a good start. Mind sharing more about the run time failure?

@aeneasr may I know if you've time to contribute a fix or would like to sponsor the work?

@diorcety can you please update the test spec `modules/openapi-generator/src/test/resources/3_0/python-fastapi/petstore.yaml` with a test or 2 and update the samples so that the CI can verify the change?

I've filed https://github.com/OpenAPITools/openapi-generator/pull/19830 and limited the change only to python fastapi (as python client generators do not use the `responses` at the moment)