William Cheng

Results 983 comments of William Cheng

@aanno2 can you please file a PR (or update this PR) to include only the enhancements without updating all the samples to start with? That will make it easier to...

@aanno2 can you please resolve the merge conflicts when you've time?

> openapi-generator-cli generate --additional-properties=removeOperationIdPrefix=true,removeOperationIdPrefixDelimiter=.,removeOperationIdPrefixCount=-1 ... those are global/general options (available to all generators) and it shouldn't be set via additional properties (which is for generator's options)

can you try the following instead? ``` java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -i https://geoserver.dx.ugix.org.in/api -g python --remove-operation-id-prefix --additional-properties removeOperationIdPrefixDelimiter=.,removeOperationIdPrefixCount=-1 ``` I though all 3 are global options and I was wrong....

thanks for confirming the command works. let's keep it as it's for the time being (because flipping the option to make it global will likely break some use cases out...

I've filed #14898 to workaround the issue using the openapi-normalizer. ``` java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g csharp-netcore -i /tmp/a.yaml -o /tmp/c2 --openapi-normalizer SIMPLIFY_ONEOF_ANYOF=true,SIMPLIFY_ANYOF_STRING_AND_ENUM_STRING=true ```

i've updated the samples locally, ran the tests and got some errors: ``` 6) OpenAPI\Client\ObjectSerializerTest::testToQueryValue with data set "form 0.0 float, explode on, required true" (0.0, 'field', 'float', 'form', true,...

If anyone would like to contribute a R generator to Swagger-Codegen, here is a good starting point: https://github.com/swagger-api/swagger-codegen/issues/2231 For those who are not familiar with Java, another approach is to...

thanks for the PR. overall it looks good as it simplifies the code. can you please resolve the merge conflicts when you've time? we can definitely give it a try.