William Cheng
William Cheng
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in...
please resolve the merge conflicts when you've time. cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero...
> @kuhnroyal @wing328 Can you check why the tests were passing here when there was a compile error for the generated code? The test did run and passed. Does it...
Can you please paste the compilation error here as well? I'll try to repeat that locally.
> It's probably because I force pushed the update to my own branch, and the tests didn't re-run here. To trigger the run, please update the samples and the Github...
yes please update the samples as the CI fails: https://github.com/OpenAPITools/openapi-generator/actions/runs/3086648029/jobs/4991237644
cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09)
@dhedey thanks for reporting the issue and suggesting 2 possible fixes. Which one do you prefer? Do you mind filing a PR with a fix you prefer to start with?
> If you want this feature added, how about you write a PR adding it? The validation should be better added to the [swagger-parser](https://github.com/swagger-api/swagger-parser) (dependency) instead.
Since it's a breaking change with fallback, we'll target 6.2.0 release.