Will Thames

Results 67 comments of Will Thames

As far as I recall, this isn't possible (and I'm not sure what in MetaMainHasInfoRule suggests that it would be possible, so maybe I'm misunderstanding what you're asking - unless...

As the configuration that comes with ansible-review is supposed to be only an example, set up the ansible-review configuration to point to your own copy of standards.py and remove the...

You are indeed quite right, but 'should be adjusted' understates things somewhat as it's really 'should be rewritten almost entirely from scratch'. I have the same problem with ansible-inventory-grapher, I...

ansible-review is not a substitute for ansible --syntax-check That said, it should handle this exception better, you're quite right.

I'd probably need to use a bit more of ansible's block processing logic, which could cause other problems. Does this pass `ansible --syntax-check`? (I have no plans to solve problems...

Hi Eric, The examples provided with ansible-review are examples. Of course it also provides the underlying function which is very much targeted at our particular YAML standards. There are no...

Also, as long as you and your colleagues agree, what I think is irrelevant. And if one day the Ansible community agrees on a single standard, we'll likely modify our...

I'm not sure I agree with your last point - lots of different ways of writing yaml are valid. But not necessarily meeting an organisation's standards. I could run `ansible-playbook...

I'd definitely accept a patch that used yamllint for the yaml validation. I'd still like to make it configurable though, not really sure how best to do that though -...

Hi Jordan, This is how I would do it. Add a `PythonCode` and a `PowershellCode` subclass of `Code`. In `classify`, if it ends with .py, make it `PythonCode`, if it...