Will Thames

Results 67 comments of Will Thames

I think on balance I'd just prefer ease of choice of templates - perhaps provide a mechanism of switching between different provided templates. I'd like to preserve the existing template...

I think ansible-review should use the standard ansible.cfg mechanism, so it might be that we're just not checking for the presence of that configuration parameter when decrypting vault files. For...

@ansiblejunky it shouldn't be now but I don't use vaulted files these days so I'm not sure I've tested it - like you, I find the encrypt_string makes for much...

As discussed elsewhere, I think if we augment ansible.cfg with an [ansible-review] section, that should be relatively flexible.

I actually created an `.ansible-review` directory today with a config file in it - this would have saved me passing the extra `-c`. I might test this in the next...

I think the PR as it stands looks pretty good. I'd just like to test it - I'll try and do that next week

Apologies for not having spotted this before (I haven't looked at ansible-review in an age) This looks great - I'd really like it if there were a test case for...

I've included this in the fix_ansible_inventory branch This is now available for testing on 0.14.0rc1 I'd still like to see some test cases, mostly because I haven't hit this issue...

@benagricola that's a fair point, we don't actually have tests for including those standards. I'll double check this works fine on my own repo at work and at some point...

Thanks @ansiblejunky - I clearly missed testing it without that value set.