wilson chen

Results 70 comments of wilson chen

Hi @palemieux. Since validator of`oneOf` and `anyOf`, the error instance with longer `ValidationError.path` will be considered as better matches in `best_match`. I added one more layer of `schema` and `Instance`...

I plan to add a warning to the validator_for function. The result displayed after implementation is: ``` validators.py:965: UserWarning: missing $schema properties ``` I wonder if this meets the requirements?

@Julian Do you think the results mentioned above have met your expectations?

@FuhuXia The PR #717 could solve your problem.

Thanks for your feedback, I have passed the test on the current latest master branch, put `sample.json` and `sample.schema` in the jsonschema root directory and then executed `jsonschema -i sample.json...

@FuhuXia Sorry, I ignored to invalidate the ID. Using the test case below, I am sure it can be verified normally. But the command line mode is indeed still invalid....

> v3.2.0 will complain missing required `name` property, but master branch will overlook it. @FuhuXia Yes, I also noticed this. It may take some time to look. After I installed...

@Julian I'm sure there must be a bug in this line: https://github.com/Julian/jsonschema/blob/756de12c69de8416469041a943ce9861b8e88141/jsonschema/cli.py#L195 The type of `arguments["schema"]` is str, When this type of str parameter is passed to `validator_for` will always...

@jaredgrubb Maybe the PR python-jsonschema/jsonschema#717 could solve your problem.

There are two warnings left. ``` celt/rate.c:251:82: warning: unused parameter ‘prev’ [-Wunused-parameter] int *ebits, int *fine_priority, int C, int LM, ec_ctx *ec, int encode, int prev, int signalBandwidth) ^~~~ celt/rate.c:251:92:...