Will Frey

Semantic highlighting for cached_property?

10

The semantic highlighting has been quite helpful to me, especially how `@property`-decorated methods appear like class and instance attributes would instead of methods. Would it be possible to have `@functools.cached_property`-decorated...

Include return type annotation in `Encoding` class properties?

1

It would be tremendously helpful if you could include the return type information as an annotation. The information is already included in the docstring, so would it be possible to...

JSON schema files for project and user settings?

1

### Issue description or question Could you provide JSON schema files for your project and user settings? This would make changing (and exploring) the settings options available right from an...

Relax `HeaderTypes` type alias definition

1

This replaces `Dict[..., ...]` with `Mapping[..., ...]` in the union definition for `HeaderTypes`. Closes #2314. - [x] Initially raised as discussion #2314

https://github.com/encode/httpx/blob/3aa441015820a41861bff9b0e78d787b1a4f2f68/httpx/_types.py#L46-L47 Could `Dict` be replaced with `Mapping` in this type definition? This change would placate the type-checker when I do something like the following: ```python3 from collections.abc import Mapping from...

Rename `allow_regex` and `ignore_regex` in `snapshot_download` to be consistent with `fnmatch`

4

https://github.com/huggingface/huggingface_hub/blob/3e72bc876d72855445a3c204f483eb761eb91da5/src/huggingface_hub/snapshot_download.py#L214-L223 In the above, `fnmatch` is being used to filter files against `allow_regex` and `ignore_regex`. Acknowledging that I might be being overly pedantic here, [the official docs for fnmatch](https://docs.python.org/3/library/fnmatch.html) include...

Request: don't mutate positional-only signature marker

2

Hi there! Thanks for all your work on mutmut! As if Python 3.8, you can use the `/` character in a function/method signature definition to mark all the preceding parameters...

Update ResponseT type alias

1

Pyright treats explicit and implicit `Any` differently, with implicit `Any` being treated as `Unknown`. Pyright raised a warning indicating an unknown member type for 'Awaitable' when used in 'ResponseT'. Using...

### Pull Request check-list _Please make sure to review and check all of these items:_ - [x] Do tests and lints pass with this change? - [x] Do the CI...

The return type was incorrectly annotated as a single Iterator with a union of tuple shapes. It now uses `@overload` to reflect that `yield_label=False` returns `Iterator[tuple[Segment, TrackName]]` while `yield_label=True` returns...