William Findlay
William Findlay
> I can successfully filter out the metrics based on what is asked for, here is the [sample code](https://gist.github.com/prateek041/2967ba62ab986aa30f52d8d34ce36514). so I have an Idea of how to implement the checker...
@prateek041 If you think you have enough concrete pieces, I'd be happy to take a look. Otherwise it's also fine to wait until you have a little more.
I'm also running into this with: ``` plotly==5.4.0 plotly-express==0.4.1 kaleido==0.2.1 ``` Thanks for the workaround @vincentliuheyang, it works well for me.
The following changes to `am_pm()` fix the bug: ```rust fn am_pm(name: &str, mut hour: u32) -> DateResult { if name == "pm" { if hour != 12 { hour +=...
LGTM, I just left a few nits/comments. Feel free to take them or leave them.
Please fix the merge commit to have a proper description. Also `` seems to be messing up our signed-off-by detection. Could you replace it with your email like you did...
Needs formatting with `goimports`.
> Requesting you to accept this in 1 commit itself as they are very small changes and I have given explanation on description Could you reflect this description in the...
@sadath-12 also it should be relatively easy to split this into separate commits. Here's how you can do it: 0. Make a backup copy of your branch with `git branch...
Let's make a good first issue to do the migration to the microservices demo. I think it makes a lot of sense.