Fix: monitoring BPF maps

[sadath-12]

This pr Closes #1774 considering all its points and 1st part of https://github.com/cilium/tetragon/issues/1775

Let's break down the changes applied considering #1774 point wise

1. • seems to be solved by removing eventcache as it was supposed to be on user side and the user side EventCacheCount seems sufficient
2. • _gauge suffix removed
3. • processLru migrated towards ProcessCacheTotal as separate metric and eventcache removed as said in 1)
4. • map_errors_total text rewritted
5. • map_drops_total removed and in its place ProcessCacheEvicted used

[sadath-12]

WIP !

[kkourt]

Moved to draft since it seems to be WIP.

[sadath-12]

Moved to draft since it seems to be WIP.

yes thank you @kkourt

[sadath-12]

ready to review

[lambdanis]

@sadath-12 I see your PR has conflicts with the main branch, can you rebase?

[sadath-12]

Done @lambdanis

[lambdanis]

@sadath-12 It seems commits are still a bit off. You can check this in the checkpath action run (here).

There should be no merge commits, and ideally different tasks you implemented in this PR should be separate commits - they're quite independent of each other, so separate commits would make it easier to review the git history. I think it would be good to rewrite the git history here:

git reset HEAD~2
git add -p
# add only changes for a single task
git commit
# repeat git add, git commit for other tasks

[netlify[bot]]

✅ Deploy Preview for tetragon ready!

Name	Link
🔨 Latest commit	5305df283cdac9e3ccf348306942ef3de33b4741
🔍 Latest deploy log	https://app.netlify.com/sites/tetragon/deploys/65e161822f87730008423a67
😎 Deploy Preview	https://deploy-preview-1950--tetragon.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[willfindlay]

Please fix the merge commit to have a proper description. Also <[email protected]> seems to be messing up our signed-off-by detection. Could you replace it with your email like you did for the other commit?

[willfindlay]

Needs formatting with goimports.

[lambdanis]

@sadath-12 Could you split the changes into logical commits? As there are five different fixes, it would make sense to have five separate commits for them in this case.

[sadath-12]

Hi @lambdanis . If there are 5 commits and let's say there was a review on the 3rd commit and pushed the new changes by squashing would it reflect on the 3rd commit ? . Requesting you to accept this in 1 commit itself as they are very small changes and I have given explanation on description

[willfindlay]

Requesting you to accept this in 1 commit itself as they are very small changes and I have given explanation on description

Could you reflect this description in the commit message body? It's empty at the moment.

[willfindlay]

@sadath-12 also it should be relatively easy to split this into separate commits. Here's how you can do it:

0. Make a backup copy of your branch with git branch -c backup
1. git reset --soft HEAD~1 to remove the existing commit but keep the changes.
2. git add -p
3. Select the changes you want to include in commit 1 following the instructions on the screen.
4. When you're done, write the commit message.
5. Repeat step 2-4 until there are no changes left.
6. When you're happy with it, force push.

[sadath-12]

Ya I can separate the commits like 1,2,3,4 . if after review I get changed related to 2nd commit how I make a new change and squash it under 2 ?

[lambdanis]

Ya I can separate the commits like 1,2,3,4 . if after review I get changed related to 2nd commit how I make a new change and squash it under 2 ?

@sadath-12 Create a temporary commit, then use git rebase -i HEAD~4 (interactive mode which allows you to rewrite the git history - reorder, squash, amend previous commits).

[lambdanis]

@sadath-12 I see the CI is failing because of a commit message being too long: https://github.com/cilium/tetragon/actions/runs/8004683889/job/21862554217?pr=1950

Could you rephrase it to fit the characters limit?

[sadath-12]

@sadath-12 I see the CI is failing because of a commit message being too long: https://github.com/cilium/tetragon/actions/runs/8004683889/job/21862554217?pr=1950

Could you rephrase it to fit the characters limit?

ya reworded that . Tried to explain in description without making much sense (but enough) in the title of commit msg

[jrfastab]

@lambdanis @willfindlay could you take a look and merge if its ready to go? Thanks. CI failure there is something unrelated, I see this failure from time to time.

[lambdanis]

Thanks @sadath-12 for the updates. The code changes look good now. I rewrote the commit messages to describe exactly which metrics changed and split some commits to not mix up different changes. I dropped the _gauge suffix removal, as it's a breaking change that's hard to justify as a bug, so it shouldn't be mixed up in one PR with unrelated changes IMO. I also rewrote the PR description to include a release note.

[lambdanis]

The CI failure is a known issue: https://github.com/cilium/tetragon/issues/2010. I'm merging this PR.