William Findlay
William Findlay
It would be nice to use this for arbitrary files in general. For example, one use case I can think of is spell/grammar checking in git commit messages.
Aha, ostensibly this looks quite simple to add support for arbitrary files. Although for your use case maybe a bit trickier since you only want to look at comments. https://github.com/valentjn/vscode-ltex/pull/646/files
@kkourt I've seen this similar flake a few times in various tests. Seems like a legit bug but hard to reproduce. We had an issue about it here #39 for...
@alessandrod I'm going to try and take on the more general refactor of aya-gen to aya-tool this week (#87), which will include this change.
@alessandrod Slight problem -- In order for this to work as you described, allowing you to pass flags directly to bindgen, we would need to invoke bindgen as a command...
> Yep I've ran into this before. Using the builder, then calling `command_line_flags()` and spawning is the best we can do I think? Alright. > (in fact it's what I...
> Would it make more sense to expose grpc via a unix socket instead? Yes, we've actually had offline discussions about this before but nobody has gotten around to it...
@kkourt I ended up sticking with the polling approach for now. There are some code paths that aren't being hit 100% of the time in particular for map unloads that...
> Should we open an issue? If you have some notes/guidelines about how to go about this, seems like a good time to write them down. Yes definitely. I'll put...
Perhaps we can take some inspiration from my ringbuf implementation in [libbpf-rs](https://github.com/libbpf/libbpf-rs/blob/master/libbpf-rs/src/ringbuf.rs). We ended up getting a nice API that supports capturing closures as callbacks.