Thomas Phipps
Thomas Phipps
@zmingee Can you please fix the conflicts in this?
@Oloremo thank you for the PR. looking at it does look like it changes the functionality in #56881 so this would be correct to add. Can you fix the conflict...
awesome. when you do get time to add a test all we would need is one that tests that the wait argument is indeed changed when a timeout is supplied.
> @whytewolf > > > when you do get time to add a test > > No idea, I tried to setup dev env on a new MacBook and I...
@twangboy pre-commit fail.
@dithmer can you update this PR as well. it looks to be out of date with the master branch to the point i can't update the merge in github.
So, I'm not sure this does fix the original issue. just kind of sweeps it under the rug and ignores a lot of other issues with buffering. also test cases...
> I know you're trying to help. But please let the devs handle this. Thanks. @OrangeDog is right, this needs tests. And it also needs a changelog file. Also please...
@ctramnitz Can you please fix the pre-commit issue? instructions on pre-commit can be found at https://docs.saltproject.io/en/latest/topics/development/contributing.html#pre-commit-and-nox-setup
@zmingee can we get a basic docstring on get_metadata that is what the main failure in the checks is about. also you might want to run pre-commit on your local...