salt
salt copied to clipboard
saltstack
WIP: Unhardcoded wait timeout for minion refresh event
What does this PR do?
Unhardcoded wait timeout for minion refresh event
What issues does this PR fix or reference?
Partially Fixes: #20590
Previous Behavior
Timeout was hardcoded to 30 seconds
New Behavior
Timeout is 30 seconds by default but will be overridden if timeout argument was passed in saltutil.refresh_pillar for example.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
- [X] Docs
- [X] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
- [ ] Tests written/updated
Commits signed with GPG?
Yes
A similar feature was implemented for pillar: https://github.com/saltstack/salt/pull/56881
@Oloremo thank you for the PR. looking at it does look like it changes the functionality in #56881 so this would be correct to add.
Can you fix the conflict with the pre-commit-config?
@whytewolf almost forgot re this PR, I didn't have time to write a test so I add WIP and didn't expect it to be noticed. Let me try to update it.
awesome. when you do get time to add a test all we would need is one that tests that the wait argument is indeed changed when a timeout is supplied.
@whytewolf
when you do get time to add a test
No idea, I tried to setup dev env on a new MacBook and I failed. It installs half of the internet, some libs are absent I honestly have no idea why it's so heavy just to run black and isort? I guess the docs part is complicated and I'd suggest splitting pre-commit to the necessary and full or something.
@whytewolf
when you do get time to add a test
No idea, I tried to setup dev env on a new MacBook and I failed. It installs half of the internet, some libs are absent I honestly have no idea why it's so heavy just to run black and isort? I guess the docs part is complicated and I'd suggest splitting pre-commit to the necessary and full or something.
it isn't just black, isort and lint. the heaviest part of pre-commit is actually the requisite checking. which is why it pulls down everything to make sure it knows what gets pulled down. this includes every requisite needed to run tests. which is needed to make sure the test environments are not broken and have every lib needed to run the tests.
Also, currently I don't think salt supports M1 based macs so that might be one of the reasons you might be having trouble.