Ian Whyman

Results 138 comments of Ian Whyman

Yes, this would be amazing for easily finding the worst offenders!

We dont do anything clever currently and just rely on CMake to find iconv and do the right thing. https://github.com/gerbera/gerbera/blob/master/CMakeLists.txt#L319-L320

Can you make ninja print the compiler commands like the `VERBOSE_MAKEFILE` flag does?

We cant link to libfswatch because its GPLv3 or Apache 2, both are not compatible with GPLv2.

Hey, Im not sure this is supported? How would we implement it?

Hello, thanks for taking the time to report. We work out which interface the IP is on, if you provide and IP and then simply pass that to libupnp's `UpnpInit2`....

Yeah, its odd behaviour! Ideally what we need is the ability to pass the IP to libupnp directly

I think for simplicity you would want to point at a single icon file and generate the files in the various formats from that as needed.

ImageMagick seems like a sensible choice to me. We will probably need the same functionality for some other things (resizing thumbnails) in the future.

Isnt the `config` part of `icon-config` redundant? I'm wondering if the sizes/types should even be configurable? AFAIK they are set by the UPNP standard. Looks good though!